search

rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
98.24k stars 12.7k forks source link

llvm/msvc: IsStatement in codeview data is always false #38262

Open xanlpz opened 7 years ago

xanlpz commented 7 years ago

Each entry in the line table FilenameSegments has a 'IsStatement' member. LLVM hardcodes this to 'false', while in MSVC they seem to basically be always 'true'. Changing the default, at the very least, is trivial, but we don't know what this does. None of the Google employees I have asked know (they have mentioned DWARF has something similar which is also unused though), so I'm trying to ask someone at Microsoft.

(cc @michaelwoerister)

steveklabnik commented 4 years ago

Triage: no idea what the status of this ticket is.

wesleywiser commented 1 year ago

Visited during wg-debugging triage. The fStatement bool works as described above and msvc seems to unconditionally set it to true. I don't see any harm in matching behavior here, although it seems to be unused as Windows debuggers don't seem to care about this data at all. Triaging P-low just to be conformant.