Closed alexcrichton closed 7 years ago
Possibly related to https://github.com/rust-lang/rust/pull/40319 ? (cc @eddyb -- you think?)
Hi guys, thank you very much for the report, love your work!
I have added some explicit lifetimes around. I'm not exactly sure it's related to #40319 however, now it appears that invocation of self.do_the_music
borrows volumes
for the whole lifetime of performer_buffers
(https://travis-ci.org/dnsl48/yamlette/jobs/217654253).
I would appreciate if you could confirm this assumption, which frankly seems to be correct behaviour to me now.
Feels like I've been using some fault technics to trick the borrow checker there. Probably I'll have to rewrite this place a bit. At the moment I'm doing lots of refactoring all over the library anyways, and I'm glad there's one more place to be rewritten in a more proper way.
Cheers
@dnsl48 looking at those diffs, it's not obvious to me why those patches should be needed. I'll try to build your crate locally and investigate.
@dnsl48 trying to build the crate, I agree that the current error is correct. As you said, do_the_music()
borrows volumes
for the whole lifetime of performer_buffers
, since data from volumes
is put into performer_buffers
.
This is #40319, which was not marked as relnotes. Marking as relnotes myself.
Closing, since the PR in question ins tagged as relnotes now. (Thanks @arielb1)
https://github.com/dnsl48/yamlette
cc @dnsl48