rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
96.34k stars 12.45k forks source link

Update docker images to share scripts when possible #42201

Closed malbarbo closed 7 years ago

malbarbo commented 7 years ago

https://github.com/rust-lang/rust/pull/41958 added the possibility of sharing scripts used in docker images. This allows, for example, to use the same script to install sccache in all images, consequently updating sccache can be done updating only one file.

We should update all images to share scripts when possible.

To update an image, one can follow these sequence of steps:

List of images (unchecked images need to be updated):

malbarbo commented 7 years ago

cc @alexcrichton

alexcrichton commented 7 years ago

Thanks for writing this up @malbarbo! If you're interested, want to write out some detailed steps for how to accomplish this? If we've got that listed we could likely list this as E-easy which would probably help get the work items here picked off very quickly!

malbarbo commented 7 years ago

@alexcrichton I wrote the steps. What do you think? Is it enough?

alexcrichton commented 7 years ago

Looks great! If anyone's got any follow-up questions please feel free to ask here!

@malbarbo I think there were some examples of this in a previous PR of yours as well, mind linking those here?

malbarbo commented 7 years ago

@alexcrichton I linked the android dockerfile updates.

alexcrichton commented 7 years ago

Looks like @venkatagiri has taken care of the cross image!