Refactorings for rustc_codegen_ssa - Githubissues

rust-lang / rust

Empowering everyone to build reliable and efficient software.

https://www.rust-lang.org

Other

96.54k stars 12.47k forks source link

Refactorings for rustc_codegen_ssa #56108

Open bjorn3 opened 5 years ago

bjorn3 commented 5 years ago

This is a list of things I noticed in rustc_codegen_{utils,ssa} which I did like to be changed.

[x] Move https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_utils/symbol_names/index.html to rustc_codegen_ssa.
[x] Remove https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_codegen_utils/lib.rs.html#64 (now unused)
[ ] https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/debuginfo/enum.FunctionDebugContext.html
- [x] Inline debuginfo_disabled_message and should_be_ignored_message into as_ref.
[ ] https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/debuginfo/struct.FunctionDebugContextData.html
- [x] Remove the Cell from the field source_locations_enabled and adapt several functions to take a mutable reference to FunctionDebugContext{,Data} instead.

Edit:

[x] https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/traits/backend/trait.BackendTypes.html Context is not used inside rustc_codegen_ssa
[ ] ~~https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/traits/type_/trait.BaseTypeMethods.html~~ https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_llvm/context/struct.CodegenCx.html#method.set_struct_body Why is set_struct_body even a thing?
[ ] https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/traits/consts/trait.ConstMethods.html All methods take &self, but a codegen backend may need to mutate stuff to create values.
[ ] https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/traits/statics/trait.StaticMethods.html All methods take &self, but a codegen backend may need to mutate stuff to create values.

Edit: update for current status

bjorn3 commented 5 years ago

cc @eddyb

eddyb commented 5 years ago

I agree with all of these.

There are also comments on #55627 that were left unaddressed, to avoid bitrot, that could be done now.

cc @denismerigoux @sunfishcode @michaelwoerister

bjorn3 commented 5 years ago

The following comments from #55627 by @eddyb likely still need to be addressed (none confirmed yet, because of the amount)

bjorn3 commented 4 years ago

@rustbot modify labels:+A-cranelift