The `push_*` printing in `librustc_monomorphize` should use the printing infrastructure

rust-lang / rust

Empowering everyone to build reliable and efficient software.

https://www.rust-lang.org

Other

97.96k stars 12.68k forks source link

The `push_*` printing in `librustc_monomorphize` should use the printing infrastructure #60582

Closed varkor closed 5 years ago

varkor commented 5 years ago

E.g. push_const_name here: https://github.com/rust-lang/rust/blob/d98a165e39a3634eeac2b1f35c81560f5a7e8ded/src/librustc_mir/monomorphize/item.rs#L398 See https://github.com/rust-lang/rust/pull/53645#discussion_r281194070.

eddyb commented 5 years ago

I didn't mean const printing, sorry. But rather that entire push_* stuff, which was hacked together for the monomorphization collector but can now use the printing infrastructure.

Mark-Simulacrum commented 5 years ago

This code now lives in https://github.com/rust-lang/rust/blob/929b48ec98aaff2239257574b5897f419cec2647/src/librustc/ty/print/obsolete.rs as far as I can tell, so this is probably a duplicate of https://github.com/rust-lang/rust/issues/61139 at this point. Closing as such.