rustdoc: Built-in macros are not documented in all the necessary locations

petrochenkov commented 5 years ago

:negative_squared_cross_mark: https://doc.rust-lang.org/nightly/core/default/index.html doesn't contain the derive macro Default. :heavy_check_mark: Compare with the https://doc.rust-lang.org/nightly/std/fmt/index.html page which contains the derive macro Debug because it's introduced through a reexport rather than directly.
:negative_squared_cross_mark: Some built-in macros not available through the libcore root are documented in the root instead (e.g. derives) - https://doc.rust-lang.org/nightly/core/index.html.
:heavy_check_mark: libcore prelude is documented correctly https://doc.rust-lang.org/nightly/core/prelude/v1/index.html
:negative_squared_cross_mark: https://doc.rust-lang.org/nightly/std/default/trait.Default.html doesn't contain the derive macro Default. :negative_squared_cross_mark: Note that https://doc.rust-lang.org/nightly/std/fmt/index.html doesn't contain the derive macro Debug as well.
:negative_squared_cross_mark: Derive and attribute macros in libstd prelude https://doc.rust-lang.org/nightly/std/prelude/v1/index.html has to be marked with #[doc(hidden)] currently because otherwise they generate dead links failing the linkchecker testing. As a result they do not appear on the page. What is worse, due to #[doc(hidden)] some traits with names matching derives (e.g. Default) are also not documented at that location.

petrochenkov commented 3 years ago

Looks like everything mentioned in this issue was fixed, and https://github.com/rust-lang/rust/pull/83155 removes the #[doc(hidden)] attributes as well.

pierwill commented 2 years ago

@jyn514 Can we close this?

jyn514 commented 2 years ago

My understanding is that the macros with doc(hidden) still aren't documented anywhere, since https://github.com/rust-lang/rust/pull/83155 was closed.

rust-lang / rust