search

rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
99.14k stars 12.8k forks source link

Linkchecker tool report failed for a non-English heading in a translation of TRPL #89060

Open thinh9e opened 3 years ago

thinh9e commented 3 years ago

URL to the section(s) of the book translation with this problem: https://rust-lang-vn.github.io/book/ch01-02-hello-world.html

Description of the problem:

I'm translating the section 1.2. Hello, World! into Vietnamese. For the link:

-[troubleshooting]: ch01-01-installation.html#troubleshooting
+[troubleshooting]: ch01-01-installation.html#xử-lý-sự-cố

After I commit, the Actions CI report failed on task Run lints that runs the linkchecker script from this repo:

ch01-02-hello-world.html:222: broken link fragment `#x%E1%BB%AD-l%C3%BD-s%E1%BB%B1-c%E1%BB%91` pointing to `ch01-01-installation.html`
...
Error: Process completed with exit code 1.

I double-checked it manually and confirmed it wasn't a broken link as reported. I think the linkchecker tool can't compare between raw string #xử-lý-sự-cố and encode string #x%E1%BB%AD-l%C3%BD-s%E1%BB%B1-c%E1%BB%91. Thanks!

carols10cents commented 3 years ago

Hi! Please feel free to disable the linkchecker in your translation repo until this is fixed. The linkchecker is actually in the main rust-lang/rust repo, so I'm going to move this issue over there. Thanks!

carols10cents commented 3 years ago

To be clear: we are not currently merging translations into TRPL's repo and shipping them with Rust, so this won't break Rust currently, but we might someday and it'd be nice to have this fixed in general :)