rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
99.06k stars 12.8k forks source link

Tracking Issue for "jump to definition" #89095

Open GuillaumeGomez opened 3 years ago

GuillaumeGomez commented 3 years ago

Here what are the remaining things to be done:

Steps

To go through stabilization, we will gradually enable it in different places:

Implementation history

  1. The initial PR which added the links to definition in the source code pages: https://github.com/rust-lang/rust/pull/84176
  2. Add links for primitives in "jump to definition" feature: #88033
  3. Add links for primitives: #91264
jyn514 commented 3 years ago

Enable the feature by default (on nightly only) and reverse the flag (so that it disables instead of enabling).

I think we should not do this, this is exactly how we got in trouble with intra-doc links (see https://github.com/rust-lang/rust/issues/63305). Instead we should just enable it by default at the same time we remove the flag and stabilize the feature.

GuillaumeGomez commented 3 years ago

This is a very good point. I had in mind that maybe people would want to disable it but I guess we can always add it later on if the needs appear.