Tracking Issue for cfg(target_has_atomic_load_store)

Mark-Simulacrum commented 2 years ago

The feature gate for the issue is #![feature(cfg_target_has_atomic)].

About tracking issues

Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

[ ] Adjust documentation (see instructions on rustc-dev-guide)
[ ] Stabilization PR (see instructions on rustc-dev-guide)

Unresolved Questions

[ ] Do we need a separate cfg for load/store operations, in combination with the existing cfg(target_has_atomic = ...)? (Or is cfg(accessible) enough?)

josephlr commented 2 years ago

I think the name of this feature is wrong, using it gives:

error[E0635]: unknown feature `cfg_target_has_atomic_load_store`
 --> src/lib.rs:5:12
  |
5 | #![feature(cfg_target_has_atomic_load_store)]
  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

It seems like the #[cfg(target_has_atomic_load_store = ...)] functionality still uses #![feature(cfg_target_has_atomic)]

EDIT: Note that I think the current behavior is fine, we should just update the tracking issue (as opposed to renaming a feature already in use).

RalfJung commented 1 month ago

Is there anything else guarded under cfg_target_has_atomic, besides cfg(target_has_atomic_load_store)?

rust-lang / rust