rust-lang / rustc-perf

Website for graphing performance of rustc
https://perf.rust-lang.org
616 stars 148 forks source link

License the whole `rustc-perf` repository under the MIT license #1933

Closed Kobzol closed 3 months ago

Kobzol commented 3 months ago

This repository currently does not have a top-level LICENSE file (#1880), which means that not all of its code is covered by a license. We would like to license the whole rustc-perf repository (apart from the collector/compile-benchmarks directory, which has its own licenses) under the MIT License, to make it easier to use rustc-perf in rustc source distributions. In the future, we might want to extend this license to MIT/Apache 2.0 (although currently we're aiming at MIT, as a start, since it is easier), hence we would like to ask the contributors to agree with a dual MIT/Apache 2.0 license, as a sort of future-proofing.

To do that, we need contributors that made commits to this repository (with some caveats, see below) to agree by posting a comment stating their approval to this issue. Please see instructions at the bottom of this issue if you are mentioned in the list below. I will try to also contact the contributors individually.

How did we select the list of contributors from whom we need the approval? I analyzed the commits from `rustc-perf` going all the way back to [`e99853d4777a1df001853c619eead0c891c28488`](https://github.com/rust-lang/rustc-perf/commit/e99853d4777a1df001853c619eead0c891c28488). In this commit, there was a top-level MIT license at the root of the repository, therefore all earlier commits should be MIT licensed. Then I found a set of contributors that made at least a single commit to any other directory than `collector` and `site`, because these two were already MIT licensed. I used [this](https://gist.github.com/Kobzol/f6abec15c398759d06feaa1aed86f71f) script for performing the analysis.

Related issues: https://github.com/rust-lang/rustc-perf/issues/1880, https://github.com/rust-lang/rustc-perf/issues/1927 PR with the new license: https://github.com/rust-lang/rustc-perf/pull/1881

Checkoff

To agree to the licensing terms, please comment with the following text on this issue (you can copy the text using the copy button on the right):

I license past and future contributions to the `rust-lang/rustc-perf` repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

Thank you very much!

Affected contributors:

Kobzol commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

GuillaumeGomez commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

ishitatsuyuki commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

homersimpsons commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

s7tya commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

blyxyas commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

sn99 commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

kennytm commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

weihanglo commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

RalfJung commented 3 months ago

I license all my past contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

(I don't think it makes sense for me to make statements about future contributions now, and I don't see how that is relevant for this licensing issue.)

rylev commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

alexcrichton commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

alex commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

eth3lbert commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

pnkfelix commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

SimonSapin commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

wesleywiser commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

klensy commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

jsha commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

nnethercote commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

chengr4 commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

jyn514 commented 3 months ago

... good luck.


I license all my past contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

est31 commented 3 months ago

I license all my past contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

Mark-Simulacrum commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

apiraino commented 3 months ago

I think I don't need to make any licensing explicit on my end since my only contribution was a typo fix in a perf. triage report :smile: but anyways

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

pietroalbini commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

miwig commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

tgnottingham commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

eddyb commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

ecstatic-morse commented 3 months ago

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

Kobzol commented 3 months ago

So, we got 30/31 approvals in 5 (!) days, that is awesome! Big thanks to everyone who expressed their approval.

The last remaining contributor who didn't express their approval yet, @Horki, contributed code that was since deleted and is no longer a part of this repository. Therefore I think that we should be good with moving forward with the licensing.

Kobzol commented 3 months ago

A top-level MIT license has been added: https://github.com/rust-lang/rustc-perf/pull/1881.