search

rust-lang / rustc-perf

Website for graphing performance of rustc
https://perf.rust-lang.org
633 stars 148 forks source link

Improve rendering of history graphs #1938

Closed Kobzol closed 1 month ago

Kobzol commented 4 months ago

When you open the graph history page with a single graph selected (common when coming from the compage page), it would be nice to show the graph over the full page, rather than just in a small box.

Also, some improvements could be made to improve the readability of the graph when it contains a wide range of values (https://github.com/rust-lang/rustc-perf/pull/1936#issuecomment-2208390792).

s7tya commented 4 months ago

is this mean expanding the width of graph to the screen width? CleanShot 2024-07-11 at 16 28 31@2x

Kobzol commented 4 months ago

Yes, I think that would be nice. At the very least if there is really only a single graph selected, it should expand. Does not necessarily be to the whole screen (not sure if that looks good?), but it should be larger.

s7tya commented 4 months ago

I see. it might be nice to check if both benchmark & profile option are set to determine single graph is selected. → Because of previous change, we should check the length of API resp to determine whether single graph is selected or not.