search

rust-lang / rustc_codegen_cranelift

Cranelift based backend for rustc
Apache License 2.0
1.52k stars 94 forks source link

Consider enabling "Releases" on GitHub #1337

Closed peter-kehl closed 1 year ago

peter-kehl commented 1 year ago

Hi. Looking forward to using Cranelift target with Rust.

Could you consider enabling "Releases" tab on GitHub? That would allow people to Subscribe > Customize, so that once this is public-ready, they would get notified.

Even if (later) you choose not to use Releases (and use CI instead, as per now: https://github.com/bjorn3/rustc_codegen_cranelift/issues/1210#issuecomment-984636603), you could publish a dummy release instructing people where/how to download/install it.

Thank you either way. Happy New Year.

For readers: If we don't have "Releases", you could subscribe to distributing cg_clif with rustup, which is closely related to getting this public-ready.

bjorn3 commented 1 year ago

I don't think there is much value in this for cg_clif. For the use case of downloading a pre-compiled version, the artifacts produced during CI should suffice. For the use case of knowing when to update, I don't think releases add much right now. Improvements happen mostly incrementally rather than as a big change all at once. There is also no stability difference between a concrete release and the current master branch. In the future the plan is to add cg_clif as a rustup component such that you can use the version of cg_clif corresponding with the rustc nightly you use.

jeffparsons commented 1 year ago

In the future the plan is to add cg_clif as a rustup component such that you can use the version of cg_clif corresponding with the rustc nightly you use.

At the risk of this coming across as "are we there yet"...

Can I ask what have been the main challenges in landing this? I noticed today that the PR has been open for nearly two years — quite the marathon!

bjorn3 commented 1 year ago

It's been going slower than I did like. The main blockers are listed in https://github.com/bjorn3/rustc_codegen_cranelift/milestone/2. Of these testing cg_clif in rust's CI is the most important (https://github.com/bjorn3/rustc_codegen_cranelift/issues/1290). Over the past couple of months I have slowly been working on making cg_clif's test suite suitable for running in rust's CI. Once that is done I need to wait for https://github.com/rust-lang/rust/pull/105977 to land to fix cg_clif again. After that I don't think it would be too much work to wire it up on rust's side.