search

rust-lang / rustc_codegen_cranelift

Cranelift based backend for rustc
Apache License 2.0
1.52k stars 94 forks source link

Build CI dist artifacts without debug assertions #1347

Closed bjorn3 closed 1 year ago

bjorn3 commented 1 year ago

This significantly improves performance. For example for the simple-raytracer benchmark it goes from a 13% improvement over LLVM to 39% improvement over LLVM.

bjorn3 commented 1 year ago

This should fix https://github.com/bjorn3/rustc_codegen_cranelift/issues/1344. Could you please confirm @Elabajaba? You can find the CI artifacts at https://github.com/bjorn3/rustc_codegen_cranelift/actions/runs/4091385626

bjorn3 commented 1 year ago

I'm going to merge this as it improves compile times a lot. I will leave #1344 open until it is confirmed this fixes the pathological behavior seen on Windows with CI artifacts.

Elabajaba commented 1 year ago

This should fix #1344. Could you please confirm @Elabajaba? You can find the CI artifacts at https://github.com/bjorn3/rustc_codegen_cranelift/actions/runs/4091385626

Sorry I didn't get to this earlier, I had a busy weekend.

Tested it on Windows, and this fixes the --release build compile time issue for Naga and wgpu with CI artifacts for me!

edit: Also fixed on Linux.

bjorn3 commented 1 year ago

No worries. Thanks for testing!