search

rust-lang / rustc_codegen_gcc

libgccjit AOT codegen for rustc
Apache License 2.0
905 stars 60 forks source link

Switch from actions-rs to preinstalled rustup #412

Closed tgross35 closed 7 months ago

tgross35 commented 7 months ago

actions-rs is deprecated. Switch to using the preinstalled rustup to install the toolchain, and https://github.com/Swatinem/rust-cache to configure cacheing.

https://github.com/dtolnay/rust-toolchain cannot be used because it does not respect rust-toolchain.

I believe there isn't any need to run cargo build separately anymore since there are no longer error annotations.

Fixes https://github.com/rust-lang/rustc_codegen_gcc/issues/381

tgross35 commented 7 months ago

@antoyo does matrix items libgccjit_version or commands (link) affect what is built? If so, maybe they should be part of the cache key

antoyo commented 7 months ago

@antoyo does matrix items libgccjit_version or commands (link) affect what is built? If so, maybe they should be part of the cache key

No, rustc_codegen_gcc itself is built with LLVM, so the crates used by it are not affected by those flags.

antoyo commented 7 months ago

It seems like you forgot to remove actions-rs in the gcc12 CI.

tgross35 commented 7 months ago

Good catch, removed that

antoyo commented 7 months ago

Thanks a lot!