search

rust-lang / rustc_codegen_gcc

libgccjit AOT codegen for rustc
Apache License 2.0
905 stars 60 forks source link

Implement prefetch data intrinsics #420

Open NCGThompson opened 6 months ago

NCGThompson commented 6 months ago

Fixes #414

It should probably have tests that should fail before the changes. What kind of test should I add?

I edited the builtin list in context.rs, and that might create a conflict when syncing with the rust repository.

antoyo commented 6 months ago

It should probably have tests that should fail before the changes. What kind of test should I add?

Do you know what kind of tests there is for this in the LLVM codegen?

NCGThompson commented 6 months ago

The codegen tests are probably the most thorough, but they are LLVM specific. However, according to the FileCheck documentation, it doesn't do much that can't be done with grep.

At a minimum though, I think we should check that the compiler can encounter the function without panicking.

antoyo commented 6 months ago

At a minimum though, I think we should check that the compiler can encounter the function without panicking.

I would be OK with such a test. You can add it in this directory.

antoyo commented 5 months ago

Is this still a draft or should I review this PR?