search

rust-lang / rustc_codegen_gcc

libgccjit AOT codegen for rustc
Apache License 2.0
893 stars 61 forks source link

a better description of the build system script #488

Closed g4titanx closed 2 months ago

g4titanx commented 2 months ago

i dont know why, but some of the tests are failing

GuillaumeGomez commented 2 months ago

Also, why are there 10 commits?

g4titanx commented 2 months ago

Also, why are there 10 commits?

there were supposed to be just two, I think it's between when I made a git pull, committed my changes, and then made a git push. it accounted for the recent commits I don't know why it did that tho

GuillaumeGomez commented 2 months ago

You still have 11 commits.

g4titanx commented 2 months ago

You still have 11 commits.

well, that's because I was working on that issue with a different GitHub account that got flagged and I had to create a new one. so I committed the changes I had made

GuillaumeGomez commented 2 months ago

The author of the commits is @antoyo for some of them. But in any case, please squash your commits.

g4titanx commented 2 months ago

hello @GuillaumeGomez, I have been trying to squash my commits and I haven't been able to do that, this is my first attempt at trying to squash a commit tho. I have been at it since you mentioned it, and rebase squash wasn't as easy as I thought. there must be something I am doing wrong, but I don't know what it is. I would be so glad if you could work me through it, thanks

GuillaumeGomez commented 2 months ago

A tutorial on how to squash commits.

g4titanx commented 2 months ago

tha

A tutorial on how to squash commits.

thank you!

GuillaumeGomez commented 2 months ago

You only keep on adding new commits...

g4titanx commented 2 months ago

You only keep on adding new commits...

yeah, i realized that, i am trying to figure it out