search

rust-lang / rustc_codegen_gcc

libgccjit AOT codegen for rustc
Apache License 2.0
894 stars 60 forks source link

Better removal of UI tests with errors emitted by the frontend #537

Open antoyo opened 1 week ago

antoyo commented 1 week ago

The test tests/ui/consts/const-eval/parse_ints.rs in the file failing-ui-tests.txt even though this is not something to fix on our end.

The reason it is not removed is because the test file doesn't contain any error pattern like //@ error-pattern: and we only remove tests containing those patterns. According to the documentation, a UI test is expected to generate a compile error by default, so perhaps we should only keep the tests with one of the pass headers:

badumbatish commented 1 week ago

hi! i want to start partcipating in rustc_codegen_gcc, for this task does this mean i need to go through every file in the failing-ui-tests.txt and only include the files that have //@ check-pass , //@ build-pass or //@ run-pass ?