Closed Enselic closed 2 years ago
@aDotInTheVoid Any chance you could take a look at this please? I used it again for https://github.com/rust-lang/rust/pull/100762 and find it very useful.
The diff might look compilicated, but it's very simple actually. I just extract hardcoded strings into variables.
Let me know if you have any concerns and we'll sort them out somehow!
No concerns, just hadn't gotten around to looking over it, and it seemed non-urgent.
This makes it easy for me to try out e.g. https://github.com/rust-lang/rust/pull/99787 by temporarily doing the following change in the script and then run it:
IMHO it would be overkill (and more complicated to use) if we made these changeable by script args ($2 $3 $4) instead, so I prefer this.