Open aDotInTheVoid opened 1 day ago
cargo features are supposed to be additive, but rustc-hash isn't.
rustc-hash
Consider the case where:
a
rustdoc-types
b
c
Potential fixes
BuildHasher
Crate
I think it's fine to go with 1 for now, but I'm filling this issue so I don't forget this.
Originally reported by @noratrieb on fediverse
Caused by #42
cargo features are supposed to be additive, but
rustc-hash
isn't.Consider the case where:
a
depends onrustdoc-types
with default featuresa
relies on the HashMap using the default hasher.b
depends onrustdoc-types
withrustc-hash
feature.c
depends ona
andb
a
againsrustdoc-types
withrustc-hash
enabled.a
fails to compile.Potential fixes
BuildHasher
type that doesn't expose the underlying hashing algo, so changing it is additiverustc-hash
feature, and always use it. 3.1. Drop therustc-hash
feature, and never use it.Crate
generic over the hasher type.I think it's fine to go with 1 for now, but I'm filling this issue so I don't forget this.
Originally reported by @noratrieb on fediverse
Caused by #42