search

rust-lang / rustfmt

Format Rust code
https://rust-lang.github.io/rustfmt/
Apache License 2.0
6.05k stars 888 forks source link

Update annotate-snippets #6391

Open clubby789 opened 2 weeks ago

clubby789 commented 2 weeks ago

This will allow rust-lang/rust to eliminate a duplicate dependency on two different versions of annotate-snippets. Extracted from #6366

ytmimi commented 2 weeks ago

@clubby789 Can you provide an example of what the error output looks like before and after this change?

clubby789 commented 2 weeks ago

Checking with the deprecated attr warning, there seems to be no difference in output image image

ytmimi commented 1 week ago

Taking a look at the changelog, these breaking changes stick out to me: Specifically Switched from char spans to byte spans #90, as I'm certain it was the mismatch between bytes and chars that https://github.com/rust-lang/rustfmt/pull/6084 was trying to fix.

To the best of my knowledge rustfmt has always used byte offsets so before merging I want to test to see if bumping our annotate-snippets dependency fixes anything else.