Improvement to "check all exercises"

rust-lang / rustlings

:crab: Small exercises to get you used to reading and writing Rust code!

https://rustlings.cool

MIT License

54.01k stars 10.15k forks source link

Improvement to "check all exercises" #2122

Closed Nahor closed 3 weeks ago

Nahor commented 1 month ago

Update the state of all the exercises instead of stopping with the first failure (especially given the old code was running all of them anyway, it was just ignoring the result of the later exercises). This allows the user to see all the exercises that needs to be redone instead of having to "fix/see one, run check_all, fix/see another, run check_all, ..."
Fixed the progress display frozen for a long time if/when the first threads were run after later ones
Limit the number of threads to the number of CPU cores (avoids spawning 94 cargo instances at the same time, possibly more in the future or in custom exercise sets)
Show a progress bar instead of an unappealing "Progress: xxx/yyy".
Add a command to run check all the exercises immediately (useful if they are solved without running rustlings in between)

mo8it commented 3 weeks ago

@Nahor Thanks! This is the biggest PR I reviewed since I became a maintainer. Thank you very much for implementing all of this :D

I added my changes and merged the PR. The most important change is the visualization of the progress. Check out the animation, I find it very fancy :D

I really appreciate all your work on this PR, but next time, please discuss non-trivial changes in an issue first. This applies to contributing to any open source project, not only Rustlings. I had to learn it the hard way. You put so much effort in a PR and then it gets rejected by the maintainer because it doesn't align with their vision. Don't force me or any open source maintainer to do that and cause what I had to experience 🤗

Nahor commented 3 weeks ago

@mo8it It started trivial and mostly for me to practice Rust. Then I figured it looked cool enough to submit 😊. Personally I don't mind rejections... unless the reason is lame, in which case a rejection through discussion wouldn't be any better anyway 😝. But sure, I'll try to keep that in mind.

As for the animation, indeed, it's fancy. It looks cool, but I'm not sure about scaling. If someone has a lot of exercises, it won't fit the screen anymore and won't be readable.