rust-lang / rustup

The Rust toolchain installer
https://rust-lang.github.io/rustup/
Apache License 2.0
6.19k stars 893 forks source link

Unify progress from multiple downloads #1078

Open chergert opened 7 years ago

chergert commented 7 years ago

Currently the progress bars are a bit misleading because it only tells you progress of the current stage of operation. It would be nice to provide progress across all of the work that has to be completed.

Of course, easier said than done. I presume that this would require Content-Length checks for all the downloads up front, so that some proper measurement can be done.

Another option would be to simply make each download/step be (100 / N) of the progress, but that would result in uneven progress. Not the end of the world but not ideal either.

The current situation, when automating RustUp from a UI like we do in Builder, is that our progress bar regularly jumps from 100% to 0% after each stage completes.

chergert commented 7 years ago

rustup

Attaching an example of our UI around rustup.sh in Builder to let you know where I'm coming from.

brson commented 7 years ago

Thanks for the suggestion. I'm shocked you managed to scrape rustup's output usefully at all :)

I agree there needs to be a better solution here.