Open kennytm opened 7 years ago
You're exactly right: the code that processes the previously downloaded part for checksumming purposes is hooked into the same notifier that keeps track of download progress. It shouldn't be too difficult to separate them out.
Out of interest, is this causing actual problems (apart from reporting obviously false information...)?
@jelford No actual problem, just very annoying in estimating how much time I should pay attention to the progress.
We've reworked the progress reporting code a few times since this issue was reported. Do you think it still needs further tweaking?
Repro step:
rustup update
,rustup add target
, etc.)Demo at https://asciinema.org/a/b5ayrzn7naj6td6qegq0xxyql. The speed should be around ~100 KiB/s, but at 00:59 where the download is resumed, the speed was reported to be ~1.0 MiB/s for 6 seconds, and suddenly goes back to ~100 KiB/s at 01:05.
It seems the speed calculation include the partially downloaded bytes, which it should not.