search

rust-lang / rustup

The Rust toolchain installer
https://rust-lang.github.io/rustup/
Apache License 2.0
6.18k stars 889 forks source link

Rework Main page #1372

Open t-botz opened 6 years ago

t-botz commented 6 years ago

I have some comments around the main page. Here is what I am proposing and willing to implement:

  1. Display both Windows 32 and 64 in unknown and default instructions
  2. Make unknown and default instructions way more compact so you don't need to have a huge screen to see the footer without scrolling (ideally all instructions would be the same height)
  3. Get rid of the cycling feature which is flagged off at the moment
  4. Add unix instructions also for wget (granted wget is suppported by the shell script)
  5. Add Rust favicon
  6. Add github "Fork me" ribbon instead of the "about rustup" link
  7. Add a link to the Rust Community page instead of a link to Mibbit

Related to : https://github.com/rust-lang-nursery/rustup.rs/issues/1253 https://github.com/rust-lang-nursery/rustup.rs/issues/1369 https://github.com/rust-lang-nursery/rustup.rs/pull/1268

@nrc @withoutboats @alexcrichton @Diggsey Let me know what you agree / disagree with.

nrc commented 6 years ago

1 and 2 sound good. I don't know what 3 means. 4 If we land the changes to the script to do we need the instructions? I'm in favour as long as it doesn't make the page more cluttered. 5 :+1: 6 I personally don't like the GH ribbon, but I wouldn't object based on my own prejudice. It might be better to just rename that link from "about rustup" to "source repo" or something? 7 I feel like the direct irc link is better than the community link, though maybe we could have both.

t-botz commented 6 years ago

"I don't know what 3 means." Legacy code I believe which use to cycle through installation method. It's still there but flagged off. 4 I'll suggest a design 6 I'm not a big fan of the ribbon in term of design but instinctively now on any website that I know is open source, I look for it. 7 I have a grudge against iirc, I guess I'll keep it for me :)

nrc commented 6 years ago

Legacy code I believe which use to cycle through installation method. It's still there but flagged off.

Sounds fine to remove then