search

rust-lang / rustup

The Rust toolchain installer
https://rust-lang.github.io/rustup/
Apache License 2.0
6.13k stars 882 forks source link

Investigate using a community maintained progress bar #1835

Open rbtcollins opened 5 years ago

rbtcollins commented 5 years ago

Describe the problem you are trying to solve Stop us playing whack-a-mole with progress bars. Also get nicer, shinier ones. https://github.com/rust-lang/rustup.rs/issues/1826 is perhaps a case of this (but perhaps also is just in the term detection bucket).

Describe the solution you'd like Use https://github.com/mitsuhiko/indicatif

Notes Some care is needed in investigating the behaviours involved but I think overall we could shrink rustup's code a bit, as well as directing effort on corner case configurations to a more central place, rather than the leaf node that rustup is.

rbtcollins commented 5 years ago

@mitsuhiko

mitsuhiko commented 5 years ago

I would love to get people on board to improve indicatif :)

kinnison commented 5 years ago

I think that switching to indicatif or another similar library would be an interesting approach. It'd be a significant departure for the current UI if we also funnelled all messaging through such a beast, so we'd need to think carefully.