Testing for proxying, including both TOOLS and DUP_TOOLS

rust-lang / rustup

The Rust toolchain installer

https://rust-lang.github.io/rustup/

Apache License 2.0

6.18k stars 892 forks source link

Testing for proxying, including both TOOLS and DUP_TOOLS #2739

Open workingjubilee opened 3 years ago

workingjubilee commented 3 years ago

(Note: this has been edited by the rustup team)

1.24.0 shipped with the ability to run cargo fmt, untested.

1.24.1 will not have that defect. We need to test to make sure that:

rustup correctly proxies to all of its core tools rather than the subset currently checked.
rustup correctly proxies to its DUP_TOOLS list.

rbtcollins commented 3 years ago

Rustup doesn't do the third Item on your list.

Rustin170506 commented 3 years ago

Test all proxies on macOS Catalina 10.15.7 19H2 x86_64

All proxies working well.

The package cargo-cache for cargo was also tested.

See: https://discord.com/channels/442252698964721669/463480252723888159/836798461134897152

Rustin170506 commented 3 years ago

If anyone wants to help test, you can use the following command to upgrade to 1.24.1(linux/macos/git-bash):

$ export RUSTUP_UPDATE_ROOT=https://dev-static.rust-lang.org/rustup
$ rustup self update
info: checking for self-updates
info: downloading self-update
  rustup updated - 1.24.1 (from 1.23.1)

Rustin170506 commented 2 years ago

@rustbot claim

I will try to test it.

Rustin170506 commented 2 years ago

Added unit tests to it, maybe we need better integration tests. My intention is to write a script and install and run these proxy tools in the CI, do you have a better way to test them?