search

rust-lang / rustup

The Rust toolchain installer
https://rust-lang.github.io/rustup/
Apache License 2.0
6.19k stars 893 forks source link

Consider introducing an HTML and CSS formatter for the Rustup website #4091

Open Rustin170506 opened 1 week ago

Rustin170506 commented 1 week ago

Problem you are trying to solve

As dicsusued in https://github.com/rust-lang/rustup/pull/4080#issuecomment-2481060171 and https://github.com/rust-lang/rustup/pull/4080#issuecomment-2485247199.

I think it would be a good idea to introduce a formatter for this. It would help us avoid similar situations in the future. I’d recommend using Prettier, but it does require adding a new toolchain, such as npm, pnpm, or yarn, to install it. What are your thoughts on this?

Solution you'd like

  1. Install the prettier
  2. Format the project using the default configuration.

Notes

No response

djc commented 1 week ago

I think it would be a good idea to introduce a formatter for this. It would help us avoid similar situations in the future. I’d recommend using Prettier, but it does require adding a new toolchain, such as npm, pnpm, or yarn, to install it. What are your thoughts on this?

I think the most important factor is that we can easily deploy something into CI. Beyond that, having plugins for common editors (like VS Code) might be a nice to have. I don't have a good sense of the landscape here, Prettier seems okay to me.