rust-lang / rustwide

Execute your code on the Rust ecosystem.
Apache License 2.0
180 stars 41 forks source link

Use image name with hash after pulling #24

Closed Nemo157 closed 4 years ago

pietroalbini commented 4 years ago

Is there a reason for this change?

Nemo157 commented 4 years ago

Mostly that this will log the exact image used, so that it is possible to pull it down later and inspect it from the build logs on docs.rs (assuming that hub.docker.com don't garbage collect unreferenced images, which I haven't seen them do yet).

(Just the log line added is not enough, that's not part of the logs that make it onto docs.rs, which is why it replaces the image name as well for when used as part of future commands).

pietroalbini commented 4 years ago

Ok, that's great!

Could you add a line to the changelog?

pietroalbini commented 4 years ago

Thanks!