search

rust-lang / rustwide

Execute your code on the Rust ecosystem.
Apache License 2.0
182 stars 41 forks source link

Warn when commands are not run #44

Closed jyn514 closed 4 years ago

jyn514 commented 4 years ago

I ran into bugs in docs.rs because of unused commands.

warning: unused `rustwide::cmd::Command` that must be used
   --> src/docbuilder/rustwide_builder.rs:591:9
    |
591 |         build.cmd("mkdir").args(&["iPhoneOS.platform"]);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(unused_must_use)]` on by default
    = note: call `.run()` to run the command
jyn514 commented 4 years ago

r? @pietroalbini

pietroalbini commented 4 years ago

Can you also add a line to the changelog?

jyn514 commented 4 years ago

Done.

pietroalbini commented 4 years ago

Thanks!