search

rust-lang / rustwide

Execute your code on the Rust ecosystem.
Apache License 2.0
182 stars 41 forks source link

Delete all installed toolchains when clearing caches #57

Closed Mark-Simulacrum closed 3 years ago

Mark-Simulacrum commented 3 years ago

Toolchains are essentially also cached; we should ensure their deletion.

On crater, this would save (after purging):

I am not sure if this patch is the right idea; it might be that bits of rustwide rely on toolchains existing after purge_all_caches is run. If so, we can uninstall in crater rather than relying on this function's purging...

pietroalbini commented 3 years ago

Hmm, I'd prefer to implement deletion in Crater, similar to this example in the Rustwide docs. That way we can run the deletion code unconditionally every time an experiment start without having to unnecessarily re-download the same toolchain multiple times.

Mark-Simulacrum commented 3 years ago

Sounds good. I'll try to do that; I've already done some cleanup manually on the builders so this is no longer very urgent.