search

rust-lang / rustwide

Execute your code on the Rust ecosystem.
Apache License 2.0
182 stars 41 forks source link

Update git2 to compile with latest rustc nightly #63

Closed fpoli closed 3 years ago

fpoli commented 3 years ago

This should work around the issue rust-lang/rust#85574 by including https://github.com/rust-lang/git2-rs/pull/712.

(I haven't tested this change locally.)

pietroalbini commented 3 years ago

Thanks for opening the PR!

0.13.12 is semver-compatible with 0.13.20, so you should be able to cargo update -p git2 on your project to get the latest version. Does that work for you?

fpoli commented 3 years ago

Thanks for opening the PR!

0.13.12 is semver-compatible with 0.13.20, so you should be able to cargo update -p git2 on your project to get the latest version. Does that work for you?

Good point, thanks! Updating git2 on our project is enough to work around the issue.

pietroalbini commented 3 years ago

Great! Closing the PR then.