rust-lang / simpleinfra

Rust Infrastructure automation
MIT License
146 stars 76 forks source link

`dev-desktop` is not a valid ansible group name #561

Open MarcoIeni opened 2 months ago

MarcoIeni commented 2 months ago

When running ansible version 8, the apply script shows a warning: [WARNING]: Invalid characters were found in group names but not replaced, use -vvvv to see details

This is because the group name here can't contain -.

To confirm, I also edited the apply script to add the -vvvv flag and this is the output:

Not replacing invalid character(s) "{'-'}" in group name (dev-desktop)
[WARNING]: Invalid characters were found in group names but not replaced, use -vvvv to see details
Not replacing invalid character(s) "{'-'}" in group name (dev-desktop)

Resources

jdno commented 2 months ago

This feels like another argument for something like ansible-lint. I'm pretty sure we have more places where our naming does not follow the standard/best practices. 😬