rust-lang / socket2

Advanced configuration options for sockets.
https://docs.rs/socket2
Apache License 2.0
683 stars 227 forks source link

Add Apple visionOS support #503

Closed QuentinPerez closed 4 months ago

QuentinPerez commented 7 months ago

Motivation

Add the support of Apple VisionOS 121419

Solution

Add target_os = "visionos"

Thomasdezeeuw commented 7 months ago

Can you add the target to the CI and local dev?

QuentinPerez commented 7 months ago

@Thomasdezeeuw do you mind if I use target_env = "apple" ? Instead of changing this every time Apple releases a new device

Thomasdezeeuw commented 7 months ago

@Thomasdezeeuw do you mind if I use target_env = "apple" ? Instead of changing this every time Apple releases a new device

I think that is deprecated. Or was that target_family?

Thomasdezeeuw commented 7 months ago

@Thomasdezeeuw do you mind if I use target_env = "apple" ? Instead of changing this every time Apple releases a new device

I think that is deprecated. Or was that target_family?

target_vendor is being deprecated: https://github.com/rust-lang/rust/issues/100343. For now let's stick with explicit OS, I don't really want to deal with all the target stuff a the moment, at least we know that this works.

madsmtm commented 5 months ago

target_vendor = "apple" will not be deprecated unless an alternative appears, see https://github.com/rust-lang/rust/issues/100343#issuecomment-2065159934, so I think you can safely use that

Thomasdezeeuw commented 5 months ago

target_vendor = "apple" will not be deprecated unless an alternative appears, see rust-lang/rust#100343 (comment), so I think you can safely use that

Let's still go with target_os for now, we'll let the dust settle on vendor vs. family vs. os, etc. first.

QuentinPerez commented 4 months ago

@Thomasdezeeuw do you think that we can merge ?

Thomasdezeeuw commented 4 months ago

I want to merge #520 first, then it's a lot easier to add new targets.

Darksonn commented 4 months ago

520 has been merged now.

Thomasdezeeuw commented 4 months ago

Thanks @QuentinPerez