search

rust-lang / socket2

Advanced configuration options for sockets.
https://docs.rs/socket2
Apache License 2.0
683 stars 227 forks source link

feat: Added visionOS support for Apple Vision Pro #514

Closed eugenehp closed 5 months ago

eugenehp commented 5 months ago

Saw good work in https://github.com/rust-lang/socket2/pull/503

This PR addresses the comments with target_os specifics.

Tested it with Tier 3 target.

eugenehp commented 5 months ago

CI pulls old nightly from 2018, should pull the recent one instead,

Screenshot 2024-06-04 at 10 29 23 AM
eugenehp commented 5 months ago

Looks like CI for freebsd is broken The resource 'projects/freebsd-org-cloud-dev/global/images/family/freebsd-13-2' was not found

eugenehp commented 5 months ago

This pr is not ok.

You mention #503, but then proceed to not give the author credit.

This code was done without prior knowledge of #503

You also remove another OS from the CI?

https://github.com/rust-lang/socket2/pull/514#issuecomment-2148043695

I'm sorry, but this is just unacceptable.

Ok, let me know if I can be of help with #503. Thanks.

Closing in favour of #503.

Thomasdezeeuw commented 5 months ago

You also remove another OS from the CI?

#514 (comment)

The solution is not to remove another OS, especially not within a pr that adds another.

Why not communicate with the maintainers, i.e. me, on how to solve it?

I'm sorry, but this is just unacceptable.

Ok, let me know if I can be of help with #503. Thanks.

You can leave this patch on that pr so we can further discuss adding visionOS support.

eugenehp commented 5 months ago

Thanks Thomas, didn't mean to offend with that commit, was just testing what's wrong with the CI. We've freebsd in production too. I'll take a look at the patch.