rust-lang / spec

The Rust specification
Apache License 2.0
103 stars 7 forks source link

Add a review policy #51

Closed ehuss closed 7 months ago

ehuss commented 8 months ago

This is an attempt to try to capture what I think should be guidelines for merging and reviewing, based on some of the discussion from the 2024-03-14 meeting.

I placed this within an outline of other team documentation I think we should have to give context to where it fits in. I expect to have these other sections filled in the future.

This explicitly does not cover how "final approval" is given by teams like the lang team, which I think will need a separate process.

Closes #25

JoelMarcey commented 7 months ago

@rfcbot poll "t-spec approve"

JoelMarcey commented 7 months ago

Maybe rfcbot doesn't fully work yet.

I was trying to get the t-spec team checkboxes going.

rfcbot commented 7 months ago

Team member @JoelMarcey has asked teams: , for consensus on:

"t-spec approve"

ehuss commented 7 months ago

@JoelMarcey You have to make sure the T-spec label is applied, otherwise rfcbot doesn't know which team to ping. Also, it can take ~10 minutes for it to respond since it is currently polling (once infra sets up the webhook, it should be immediate).

@rfcbot poll "t-spec approve"

rfcbot commented 7 months ago

Team member @ehuss has asked teams: T-spec, for consensus on:

"t-spec approve"

ehuss commented 7 months ago

🤷 Bot now seems confused. Here are checkboxes: