search

rust-lang / stdarch

Rust's standard library vendor-specific APIs and run-time feature detection
https://doc.rust-lang.org/stable/core/arch/
Apache License 2.0
598 stars 260 forks source link

fix use of stdsimd feature in std_detect crate #1524

Closed RalfJung closed 5 months ago

RalfJung commented 5 months ago

This is needed to fix build failures in https://github.com/rust-lang/miri-test-libstd/

rustbot commented 5 months ago

r? @Amanieu

rustbot has assigned @Amanieu. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

lu-zero commented 5 months ago

But looks like there is more broken?

RalfJung commented 5 months ago

I don't know why CI fails that way -- I don't really understand the feature flag setup here.

https://github.com/rust-lang/stdarch/pull/1523 seems related and makes all CI green, but I don't know if that will also help for miri-test-libstd.

RalfJung commented 5 months ago

https://github.com/rust-lang/stdarch/pull/1523 seems to also work for miri-test-libstd, so let's go with that one.