rust-lang / stdarch

Rust's standard library vendor-specific APIs and run-time feature detection
https://doc.rust-lang.org/stable/core/arch/
Apache License 2.0
599 stars 260 forks source link

Update test expectations for aarch64 #1528

Closed nikic closed 5 months ago

nikic commented 5 months ago

vcgez/vclez now generate different (and more obvious) instructions.

fmadd/fmsub are now preferred over the slower fmla/fmls in more cases. I believe this is specific to the LANE=0 case, but I couldn't figure out how to switch testing to use LANE=1 without also breaking the case where only LANE=0 is valid.

rustbot commented 5 months ago

r? @Amanieu

rustbot has assigned @Amanieu. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

nikic commented 5 months ago

I believe the fma change is https://github.com/llvm/llvm-project/commit/38c92c1ee2f07e3260c94d51834a97e84f93c708. I didn't try to track down the other one.