rust-lang / stdarch

Rust's standard library vendor-specific APIs and run-time feature detection
https://doc.rust-lang.org/stable/core/arch/
Apache License 2.0
598 stars 255 forks source link

Fix duplicated argument name in extern block #1576

Closed bjorn3 closed 1 month ago

bjorn3 commented 1 month ago

While rustc accepts it just fine due to what is arguably a bug, this duplication does become an issue when generating functions from the llvm intrinsic declarations while reusing the argument names.

rustbot commented 1 month ago

r? @Amanieu

rustbot has assigned @Amanieu. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

bjorn3 commented 1 month ago

CI failure is unrelated (the test thinks the int3 padding should be counted towards the instruction count and rejects it due to having too many instructions)