addcarryx: use pointers of the right type

rust-lang / stdarch

Rust's standard library vendor-specific APIs and run-time feature detection

https://doc.rust-lang.org/stable/core/arch/

Apache License 2.0

598 stars 255 forks source link

Closed RalfJung closed 2 weeks ago

RalfJung commented 2 weeks ago

I don't know why these functions use u8 in their signature, but surely they must actually be writing a u32/u64?

I also synced the doc comments between addcarry and addcarryx.

rustbot commented 2 weeks ago

r? @Amanieu

rustbot has assigned @Amanieu. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Amanieu commented 2 weeks ago

Presumably this was relevant when LLVM used typed pointers, but this isn't the case now that it has switched to opaque pointers.