search

rust-lang / stdarch

Rust's standard library vendor-specific APIs and run-time feature detection
https://doc.rust-lang.org/stable/core/arch/
Apache License 2.0
601 stars 267 forks source link

Fix documentation of arguments of function `core::arch::x86::_mm_blendv_epi8` #1598

Closed mtilda closed 3 months ago

mtilda commented 3 months ago

Fixes https://github.com/rust-lang/rust/issues/126935

This PR corrects the doc comment on the function and rewords it for clarity.

According to the issue linked above, the behavior of this function is correct and corresponds to Intel's documentation.

This can be verified by inspecting the unit tests here: library/stdarch/examples/hex.rs.

I am able to run these tests with the commands

cd examples
cargo +nightly test

So far I have not gotten ci/run.sh to work correctly. I have also had no luck with the command cargo +nightly test --example hex -p stdarch provided in this comment. But perhaps those problems are not so relevant to this PR.

rustbot commented 3 months ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) some time within the next two weeks.

mtilda commented 3 months ago

@rustbot ready

rustbot commented 3 months ago

Error: The feature shortcut is not enabled in this repository. To enable it add its section in the triagebot.toml in the root of the repository.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.