search

rust-lang / stdarch

Rust's standard library vendor-specific APIs and run-time feature detection
https://doc.rust-lang.org/stable/core/arch/
Apache License 2.0
612 stars 271 forks source link

cleanup wasm const fn #1660

Closed RalfJung closed 3 weeks ago

RalfJung commented 3 weeks ago

We shouldn't need these feature gates any more, that was just an attempt at a transition that didn't quite work out.

rustbot commented 3 weeks ago

r? @Amanieu

rustbot has assigned @Amanieu. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

RalfJung commented 3 weeks ago

Okay the try run here confirms that this will indeed work, so -- this should be good to go. :)

Amanieu commented 3 weeks ago

Should we wait until the rustc fix lands for #1661 or is the allow still needed?

RalfJung commented 3 weeks ago

That's an unrelated problem, it would pop up in any PR. Not sure if it should block this one.

The abi lint got backed out again anyway so it will be gone on the next nightly.

RalfJung commented 3 weeks ago

The new allow should be unnecessary with today's nightly, so I removed them.