search

rust-lang / sync-team

Synchronize the team repository with the services we use
Apache License 2.0
15 stars 13 forks source link

Fix restricting pushes to bots #57

Closed jdno closed 9 months ago

jdno commented 9 months ago

While working on sync-team, I noticed that the diff always contained the same change (both locally and in production):

 Team Diffs:
    💻 Repo Diffs:
    📝 Editing repo 'rust-lang/libc':
      Branch Protections:
          main
            Allowances: [] => [User(UserPushAllowanceActor { login: "bors" })]
    📝 Editing repo 'rust-lang/project-stable-mir':
      Branch Protections:
          main
            Allowances: [] => [User(UserPushAllowanceActor { login: "bors" })]

Checking the implementation, it seems that we have a bug in our code that disables restrictions when we have defined a push actor, which means the actor is never set by GitHub.