rust-lang / sync-team

Synchronize the team repository with the services we use
Apache License 2.0
15 stars 13 forks source link

Fix `allow_auto_merge` in combination with repository archiving #74

Closed Kobzol closed 6 months ago

Kobzol commented 6 months ago

1) Archived repositories might not return non-required attributes, which allow_auto_merge is. 2) Archived repositories should not be modified.

~The unwrap_or(false) part isn't ideal, but in this case we simply cannot query the GH state, so there's probably no way to calculate the real diff. In theory, this could cause us to miss auto-enabling auto merge for a repository that is being unarchived, during the first sync, but it should be resolved on the following sync.~ Actually, it should be fine, as the diff won't be missed, since we are unarchiving in the first place, so there is some diff.