search

rust-lang / team

Rust teams structure
Apache License 2.0
312 stars 287 forks source link

Add miri-test-libstd repository under automation #1255

Closed Kobzol closed 9 months ago

Kobzol commented 9 months ago

Repo: https://github.com/rust-lang/miri-test-libstd

CC @RalfJung

Extracted from GH:

org = "rust-lang"
name = "miri-test-libstd"
description = "Testing the Rust standard library with Miri, continuously"
bots = []

[access.teams]
miri = "write"
security = "pull"

[access.individuals]
rylev = "admin"
oli-obk = "write"
RalfJung = "write"
Mark-Simulacrum = "admin"
rust-lang-owner = "admin"
badboy = "admin"
pietroalbini = "admin"
saethlin = "write"
jdno = "admin"

[[branch-protections]]
pattern = "master"
ci-checks = ["Success"]
dismiss-stale-review = false
pr-required = true
review-required = false
RalfJung commented 9 months ago

Comparing the "extracted" part and what's in the PR, I am confused. Does this remove pr-required = true?

Kobzol commented 9 months ago

Sorry, the extracted format is slightly different from the TOML format, as it wasn't that easy to generate exactly the same thing.

To sum up the state proposed by the PR: PRs are required, PR approvals are not.

RalfJung commented 9 months ago

And that's the same as the current state?

LGTM.

Kobzol commented 9 months ago

Yes, it should be :)