search

rust-lang / team

Rust teams structure
Apache License 2.0
306 stars 285 forks source link

Allow specifying push allowances for branch protection #1282

Closed Kobzol closed 7 months ago

Kobzol commented 7 months ago

This enables to allow only some teams to push/merge to specific branches, to make branch protection more fine-grained.

sync-team part of this change: https://github.com/rust-lang/sync-team/pull/66

jackh726 commented 7 months ago

Seems like an alternative API here would be to allow the teams under access.teams to be able to specify allowing merging.

Kobzol commented 7 months ago

The access is per branch though, so since we already have a per-branch setting (branch protections), I think that it's better to specify it on the branch. It's more natural to identify teams by name than to identify branch protections by their pattern, IMO.