search

rust-lang / team

Rust teams structure
Apache License 2.0
308 stars 284 forks source link

Add myself to libs-contributors #1298

Closed jhpratt closed 4 months ago

jhpratt commented 6 months ago

I would like to review some PRs here and there. I don't see any way to "just" give review permissions, so I have added myself to libs-contributors. If granting me review permissions is acceptable, I don't particularly care how this works under the hood.

One question, though. Does this add me to a reviewer rotation? I would prefer to not have this be the case.

WaffleLapkin commented 6 months ago

Review rotation i tracked separately in rust-lang/rust/triage.toml. What do you mean by "review permissions", do you want to r+ libs PRs?

fmease commented 6 months ago

cc @rust-lang/libs

jhpratt commented 6 months ago

What do you mean by "review permissions", do you want to r+ libs PRs?

Basically, yes. To my knowledge r+ isn't limited to specific directories, so I would be able to review whatever within my competency. That would most often be libs code I imagine, but could conceivably be compiler code if it's something I'm sufficiently familiar with.

Ultimately I'm fine with whatever restrictions the teams would like to put on me. I just figured I could help with the backlog in a small manner.

fmease commented 6 months ago

As far as I'm aware if you'd like to officially approve compiler changes, you would need to be in at least compiler-contributors, for libs in >library-contributors and for rustdoc in >rustdoc-contributors modulo libs/rustdoc/rustfmt/clippy/rust-analyzer/... fallout (trivial to semi-trivial secondary changes necessitated by primary changes).

fmease commented 6 months ago

cc https://rust-lang.zulipchat.com/#narrow/stream/392734-council/topic/Having.20a.20team.20for.20tech.20contributors.20not.20being.20part.20of.20a.20team/near/373958311

jhpratt commented 6 months ago

I can update the PR given that it's necessary, assuming the T-compiler is okay with it. This is where having stuff written down in a more organized manner would be helpful.

cuviper commented 6 months ago

Compiler and libs both have processes for contributor membership:

I'm not making a judgement here whether you "deserve" membership, just that it's not usually self-invited.

jhpratt commented 6 months ago

Oh, I get that 100%, and I have no issue whatsoever if this is declined. I wasn't aware there was a documented process. This PR is literally me saying "I know there's a PR backlog. I will help if allowed." Nothing more 🙂

For what it's worth, I was privately asked a couple years ago (late 2021 I believe) if I wanted to be a reviewer and said I was open to it, but nothing happened after that for some reason.

Edit: Dug up the original messages, which happened early morning on October 4, 2021.

[T-libs member]: Would you be interested in joining the set of library reviewers? If you would be, I'd be happy to support your application. We could always use more reviewers. me: Not sure how much I'd be able to do, but sure! Even if it's a PR every now and then it's something.

I responded pretty much immediately and followed up four days later. I never got a response. It's not necessary to name who this is publicly, but it's naturally limited to a very small number of people. I know it's not personal, as we have talked plenty since.

m-ou-se commented 4 months ago

For the record: a library team member has recently nominated you for libs-contributors (following our usual membership process), and the team has agreed unanimously. :)

m-ou-se commented 4 months ago

Since we're also adding another new libs-contributors member, I'll send a PR for adding both of you.

Edit: Here's the PR: https://github.com/rust-lang/team/pull/1357

Amanieu commented 4 months ago

1357 is now merged, this can be closed.