rust-lang / team

Rust teams structure
Apache License 2.0
308 stars 284 forks source link

Add crates.io-index repository under automation #1306

Open Kobzol opened 6 months ago

Kobzol commented 6 months ago

Repo: https://github.com/rust-lang/crates.io-index

I'm pretty sure that this isn't correct yet. This repo should most probably not require PRs. Should I add bors to it? It's not managed by homu, but the bors GH account pushes to the repo regularly (even though it seems like it didn't have access?!), this is quite weird.

Extracted from GH:

org = "rust-lang"
name = "crates.io-index"
description = "Registry index for crates.io"
bots = []

[access.teams]
crates-io = "write"
crates-io-on-call = "write"
security = "pull"

[access.individuals]
skade = "write"
Turbo87 = "write"
tshepang = "write"
carols10cents = "write"
pietroalbini = "admin"
LawnGnome = "write"
hi-rustin = "write"
mdtro = "write"
badboy = "admin"
rust-lang-owner = "admin"
Xylakant = "write"
rylev = "admin"
jdno = "admin"
JohnTitor = "write"
Mark-Simulacrum = "admin"
justahero = "write"
jtgeibel = "write"
listochkin = "write"

[[branch-protections]]
pattern = "master"
required-approvals = 0
pr-required = false
Turbo87 commented 5 months ago

This repo should most probably not require PRs

it usually doesn't, but there have been cases where the crates.io team has opened a PR to manually fix something

Turbo87 commented 5 months ago

Should I add bors to it? It's not managed by homu, but the bors GH account pushes to the repo regularly (even though it seems like it didn't have access?!), this is quite weird.

I totally agree that it is weird, and IMHO we should change it eventually. The crates.io backend is pushing to the repository with a deploy SSH key (AFAIK) and uses git author information (i.e. email) to associate the commits to the bors GH account. those are not signed commits though, so anyone basically can create commits like that, just not necessarily in this repo.

to answer the initial question: no, bors does not need access to this repository.