Don't use `usize`s for user ids

rust-lang / team

Rust teams structure

Apache License 2.0

308 stars 284 forks source link

Don't use `usize`s for user ids #1336

Closed WaffleLapkin closed 5 months ago

WaffleLapkin commented 5 months ago

I don't think github (zulip, discord) IDs are platform dependant.

apiraino commented 5 months ago

@WaffleLapkin interesting. Do you think it could also make sense propagating this change to the triagebot (currently GH user ids are stored as i64) just for the sake of using the same type everywhere? FWIW the crate octocrab used by the triagebot agrees with you.

to be clear: not suggesting to submit a patch, simply asking for an opinion :slightly_smiling_face:

WaffleLapkin commented 5 months ago

@apiraino I actually started with the triagebot change and accidentally changed this cargo dep. so decided to submit this first and then pull changes into triagebot

Kobzol commented 5 months ago

Implemented here. But it should be merged after this one, since it will remove some unneeded casts once v1 switches to u64.