search

rust-lang / team

Rust teams structure
Apache License 2.0
306 stars 281 forks source link

Drop branch protections on llvm-project #1346

Closed nikic closed 3 months ago

nikic commented 4 months ago

To restore to something that more closely resembles the state before https://github.com/rust-lang/team/pull/1208. Merging new changes from upstream release branches into our fork doesn't really benefit from going through a PR or review, especially for work-in-progress upgrade branches.

I would have preferred to keep the "no force push and branch deletion" part of the branch protection, but it looks like disabling the PR requirement is not supported.

Kobzol commented 4 months ago

Indeed, currently in team, a branch protection means that a PR will be required.

rylev commented 4 months ago

Should we try to add a pr-required = false option so that we don't need to get rid of basic branch protection?

Kobzol commented 4 months ago

We can, but we'd be slowly starting to converge to the messy system that GitHub currently has :)

rylev commented 4 months ago

Well it feels wrong that in order to allow the release branch pattern, we are asking folks to give up on all protections.

Kobzol commented 4 months ago

It would be nice to have some better syntax for this than 5 true/false booleans though, like

[[branch-protections]]
pattern = "..."
pr = false
# pr = { required = true, min-approvals = 0 }

but we'd have to change the team data format for that.

Anyway, I'm not opposed to adding pr-required.