rust-lang / team

Rust teams structure
Apache License 2.0
309 stars 287 forks source link

Add calebzulawski to libs-contributors #1347

Closed calebzulawski closed 5 months ago

calebzulawski commented 7 months ago

From this comment, I'm wondering if I should have bors privileges: https://github.com/rust-lang/rust/pull/121269#issuecomment-1951374615

I don't think it makes sense to add bors permissions to the project-portable-simd team so adding myself to @rust-lang/libs-contributors might be correct? Feel free to suggest any alternatives, and I'm not offended if this doesn't go anywhere. Thanks!

workingjubilee commented 7 months ago

Yes, probably. I got them shortly before libs-contributors was a thing, if memory serves, so at the time I wasn't sure on what grounds I would recommend extending them, but given it exists now, that should in fact be done.

calebzulawski commented 7 months ago

cc @thomcc @Amanieu if this is libs related

m-ou-se commented 7 months ago

If this only for r+ permissions for updating the portable simd subtree, it's better to add it to people/calibzulawski.toml with a comment what it's for:

[permissions]
bors.rust.review = true # For the portable SIMD subtree.
calebzulawski commented 7 months ago

I'd also like to review PRs to rust-lang/rust that change std::simd and the compiler intrinsics (not really T-libs I guess, but I've contributed a lot more to std than to rustc). I'm not quite ready yet to be added to the rotation but my goal is to review elsewhere in std too.

calebzulawski commented 6 months ago

Learned my lesson to never try to resolve the conflicts through github... Anyway, bumping this since I'd like to be able to review a new PR and contributors expect to be able to r? me (rust-lang/rust#122905). It still sounds like lib-contributors is appropriate (the portable SIMD project group is under libs) but I added a comment to clarify.

jackh726 commented 6 months ago

This needs approval from one of @m-ou-se or @Amanieu

Kobzol commented 5 months ago

CC @m-ou-se @Amanieu (re-pinging after a few weeks)